Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace] Fix non-workspace admin update observability:defaultDashboard #2223

Merged

Conversation

yubonluo
Copy link
Contributor

Description

Non-workspace admin navigate to observability overview page that will update observability:defaultDashboard and show error toast.
image

After fixing: Only workspace owner / OSD admin can update observability:defaultDashboard

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanka

Signed-off-by: yubonluo <yubonluo@amazon.com>
@mengweieric mengweieric added bug Something isn't working backport 2.x labels Oct 22, 2024
@mengweieric mengweieric merged commit f631248 into opensearch-project:main Oct 22, 2024
13 of 22 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 22, 2024
…oard (#2223)

* Fix non-workspace admin update observability:defaultDashboard

Signed-off-by: yubonluo <yubonluo@amazon.com>

* optimize the code

Signed-off-by: yubonluo <yubonluo@amazon.com>

* optimize the code

Signed-off-by: yubonluo <yubonluo@amazon.com>

* optimize the code

Signed-off-by: yubonluo <yubonluo@amazon.com>

---------

Signed-off-by: yubonluo <yubonluo@amazon.com>
(cherry picked from commit f631248)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mengweieric pushed a commit that referenced this pull request Oct 22, 2024
…oard (#2223) (#2224)

* Fix non-workspace admin update observability:defaultDashboard



* optimize the code



* optimize the code



* optimize the code



---------


(cherry picked from commit f631248)

Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants